Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade dependencies to avoid 500 error on /oauth/callback #3075

Merged
merged 42 commits into from
Dec 22, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Dec 5, 2024

fix #3072

I bisect the past Netlify previews and it seems that the 500 error starts after merging #3046. Downgrading nuxt might fix the 500 error on /oauth/callback after log-in.

This is only a temporary workaround and I haven't found the root cause of 500 error.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 9c4dfc0
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/676047589ef9ba0008d28107

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 9c4dfc0
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/67604758398d6500094d51f3
😎 Deploy Preview https://deploy-preview-3075--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member Author

shuuji3 commented Dec 5, 2024

Unfortunately, this doesn't fix the issue yet.🥲

Screenshot of page showing "500 This page is temporarily unavailable."

@shuuji3 shuuji3 added the do NOT merge yet Do not merge this PR into the target branch yet label Dec 5, 2024
Copy link

socket-security bot commented Dec 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@shuuji3 shuuji3 changed the title chore: downgrade nuxt to ^3.13.2 chore: downgrade devDependencies Dec 6, 2024
@shuuji3
Copy link
Member Author

shuuji3 commented Dec 8, 2024

Another attempt: revert the dependencies to the point (738bc88) which is the previous commit of #3046.

@shuuji3
Copy link
Member Author

shuuji3 commented Dec 8, 2024

OK, the 500 error has disappeared now. Some of those updates should be causing the error, so we can narrow down the suspect by updating those packages little by little.

@shuuji3 shuuji3 changed the title chore: downgrade devDependencies chore: downgrade dependencies to avoid 500 error on /oauth/callback Dec 8, 2024
Copy link

socket-security bot commented Dec 9, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@shuuji3
Copy link
Member Author

shuuji3 commented Dec 14, 2024

The above commits with passed CI (✅) had no issue including chore: update nuxt-component-meta and unstorage in resolutions (90aa666) but chore: update nuxt and @nuxt/schema (b3c961e) introduced the 500 error again. So there's some issue between the previous nuxt v3.13.2 and v3.14.1592.

@shuuji3 shuuji3 force-pushed the shuuji3/chore/downgrade-nuxt branch from 69cc79b to 32e1908 Compare December 14, 2024 17:36
@shuuji3 shuuji3 removed the do NOT merge yet Do not merge this PR into the target branch yet label Dec 15, 2024
@shuuji3
Copy link
Member Author

shuuji3 commented Dec 15, 2024

nuxt>=3.14.0 doesn't work. I think we can merge this with the previous version of nuxt (v3.13.2) until we can figure out the root cause so that users can sign in on main.elk.zone again.

This might be related to ~~/shared/ folder @userquin pointed out on Nimbus:
https://discord.com/channels/1309441428061163551/1309844382693855232/1309846031726415902
but I'm not sure how exactly that's causing this issue as I cannot see it on local dev server.

@userquin
Copy link
Member

What's the server error?

@shuuji3
Copy link
Member Author

shuuji3 commented Dec 15, 2024

I can see only 500 error on Netlify preview. We need Netlify's server log to check the actually error.

@shuuji3
Copy link
Member Author

shuuji3 commented Dec 22, 2024

I'd like to merge this since it also occurs on other endpoints and blocks the other PR previews (e.g. #3033).

Examples:

We can investigate the root cause when we upgrade back to nuxt>=3.14.0 again in a separate PR.

@patak-dev patak-dev added this pull request to the merge queue Dec 22, 2024
Merged via the queue into main with commit 3b6a176 Dec 22, 2024
16 checks passed
@patak-dev patak-dev deleted the shuuji3/chore/downgrade-nuxt branch December 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot re-authenticate main.elk.zone to Mastodon
3 participants